go 1.19 go@1.18 1.18.5 by bayandin · Pull Request #107165 · Homebrew/homebrew-core

bayandin · 2022-08-02T17:30:32Z

Created with brew bump-formula-pr.

resource blocks may require updates.

carlocab · 2022-08-02T17:40:18Z

We want CI-build-dependents-from-source for major version bumps, no? Though we've got so many long-running PR jobs going I'm a bit tempted to skip it for now.

bayandin · 2022-08-02T17:45:10Z

We want CI-build-dependents-from-source for major version bumps, no?

Hmm, shouldn't the label be set automatically?

Though we've got so many long-running PR jobs going I'm a bit tempted to skip it for now.

We could try, at least once.

carlocab · 2022-08-02T17:46:49Z

Hmm, shouldn't the label be set automatically?

It should, but I think our triage workflow gets confused as soon as a PR touches more than one file.

Bo98 · 2022-08-02T18:44:14Z

go-critic and golangci-lint need revision bumps.

carlocab · 2022-08-03T08:46:28Z

octant is pre-existing. #106816

Most of the rest (build constraints, garbage collector, Go version complaints) can probably be fixed by building with a go@1.18.

That still leaves a few failures, though.

andig · 2022-08-03T08:48:29Z

@carlocab are you planning to fix Go 1.18 for part of the packages? I could help tracking the bug ones as long as Go is concerned (not python ...).

bayandin · 2022-08-03T08:49:35Z

a bunch of them should be fixed by switching to go@1.18 (will do it as soon the CI run is done)

andig · 2022-08-03T08:52:46Z

For https://github.com/go4org/unsafe-assume-no-moving-gc 1.19 is already marked safe, I'll open upstream issues.

bayandin · 2022-08-03T11:07:22Z

Formulae that require some attention (have unknown failure):

~~brew install --build-from-source grafana~~
brew install --build-from-source k3d
brew install --build-from-source liqoctl
brew install --build-from-source sync_gateway
brew install --build-from-source traefik@1

carlocab · 2022-08-03T11:12:09Z

I think grafana is also pre-existing. The error looks similar to #107028.

andig · 2022-08-03T11:32:23Z

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

carlocab · 2022-08-03T11:49:06Z

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

Maybe. Do you see a similar error with

brew install -s traefik@1

?

andig · 2022-08-03T12:35:45Z

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

Maybe. Do you see a similar error with
brew install -s traefik@1
?

Traefik has a different issue for me, but still broken:

==> Installing traefik@1
==> yarn upgrade
==> yarn install
==> yarn run build
Last 15 lines from /Users/andig/Library/Logs/Homebrew/traefik@1/03.yarn:
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:32:11)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:165:10)
    at /private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:176:18
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:47:3)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:165:10)
    at /private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:176:18
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:47:3)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at runLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:365:2)
    at NormalModule.doBuild (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/webpack/lib/NormalModule.js:182:3)
    at NormalModule.build (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/webpack/lib/NormalModule.js:275:15)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

andig · 2022-08-03T12:37:51Z

k3d currently works
liqoctl currently works
sync_gateway currently broken

andig · 2022-08-04T06:52:50Z

The fixes for go4.org are underway but likely releases will take their time (grafana/agent#1983 (comment)). Fix to 1.18 in the mean time or wait?

Update another option could be to provider wrappers:

If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set.     
Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

bayandin · 2022-08-04T08:16:54Z

I've pushed everything I have.
Meanwhile, while we're waiting for a free CI-long-timeout slot, feel free to check failed formulae on other systems (I've checked only 12-arm64 runner). Here's a link to the previous run: https://github.com/Homebrew/homebrew-core/actions/runs/2785592300

Formula/gomplate.rb

bayandin · 2022-08-05T17:17:03Z

So far, after 12-arm64, 11-arm64, linux:

Unknown:

brew test --retry --verbose func-e (on 11-arm64 only)

 ==> Testing func-e
  ==> /opt/homebrew/Cellar/func-e/1.1.3/bin/func-e run --version
  dyld: Symbol not found: __ZNKSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE3strEv
    Referenced from: /private/tmp/func-e-test-20220805-14034-7m57hu/.func-e/versions/1.22.2/bin/envoy (which was built for Mac OS X 12.3)
    Expected in: /usr/lib/libc++.1.dylib

brew install --build-from-source sync_gateway (on 12-arm64 only)

 Error: Failure while executing; `python rewrite-manifest.sh --manifest-url file:///private/tmp/sync_gateway-20220805-623-avs958/manifest/default.xml --project-name sync_gateway --set-revision e54a62741bb28f3e54a6599c21c739df9a9dad76` exited with 127. Here's the output:

Switch to 1.18:

brew install --build-from-source yorkie
brew test --retry --verbose loki

Pre-existing:

brew fetch --build-from-source --retry krakend # https://github.com/krakendio/krakend-ce/issues/541
brew fetch --build-from-source --retry whalebrew # https://github.com/whalebrew/whalebrew/issues/192
brew install --build-from-source octant # preexisting https://github.com/Homebrew/homebrew-core/pull/106816
brew install --verbose --build-bottle istioctl # preexisting https://github.com/Homebrew/homebrew-core/pull/107108

carlocab · 2022-08-05T17:30:52Z

I suggest moving the go@1.18 addition along with its dependents (the ones that build, anyway) into a separate PR to help simplify this one.

We also don't need new bottles for the ones that just have a build-only dependency on go@1.18 anyway.

bayandin · 2022-08-06T12:25:47Z

I suggest moving the go@1.18 addition along with its dependents (the ones that build, anyway) into a separate PR to help simplify this one.

We also don't need new bottles for the ones that just have a build-only dependency on go@1.18 anyway.

Ok, let's try!

BrewTestBot · 2022-08-06T14:54:26Z

@bayandin has triggered a merge.

BrewTestBot · 2022-08-06T14:54:47Z

⚠️ @bayandin bottle publish failed.

bottle publish failed

BrewTestBot · 2022-08-06T14:56:14Z

@bayandin has triggered a merge.

bayandin added the long build Set a long timeout for formula testing label Aug 2, 2022

BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 2, 2022

bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 2, 2022

bayandin added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Aug 2, 2022

Bo98 added the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 2, 2022

bayandin added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 2, 2022

Bo98 removed the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 3, 2022

This comment was marked as outdated.

Sign in to view

andig mentioned this pull request Aug 3, 2022

Support Go 1.19? quic-go/quic-go#3491

Closed

This was referenced Aug 3, 2022

Support Go 1.19 hairyhenderson/gomplate#1467

Closed

Support Go 1.19 grafana/agent#1983

Closed

Support Go 1.19 grafana/loki#6831

Closed

Error when building Docker images with Go 1.19 yorkie-team/yorkie#378

Closed

This was referenced Aug 3, 2022

krakend 2.1.0 #107225

Closed

whalebrew: update shasum #107227

Closed

SMillerDev mentioned this pull request Aug 3, 2022

traefik@1: disable #107231

Merged

6 tasks

carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 4, 2022

hairyhenderson reviewed Aug 4, 2022

View reviewed changes

Formula/gomplate.rb Outdated Show resolved Hide resolved

bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 5, 2022

iMichka added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Aug 5, 2022

iMichka mentioned this pull request Aug 5, 2022

liqoctl 0.5.4 #107374

Closed

bayandin added 3 commits August 6, 2022 13:14

go 1.19

a599d39

go-critic: revision bump for go

295915a

golangci-lint: revision bump for go

e4067f2

bayandin removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Aug 6, 2022

go@1.18 1.18.5 (new formula)

71233e4

bayandin mentioned this pull request Aug 6, 2022

Misc formulae: switch to go@1.18 #107451

Closed

bayandin changed the title ~~go 1.19~~ go 1.19 go@1.18 1.18.5 Aug 6, 2022

bayandin removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 6, 2022

bayandin requested a review from carlocab August 6, 2022 14:35

carlocab previously approved these changes Aug 6, 2022

View reviewed changes

carlocab approved these changes Aug 6, 2022

View reviewed changes

BrewTestBot closed this in 792f470 Aug 6, 2022

bayandin deleted the bump-go-1.19 branch August 6, 2022 15:04

github-actions bot added the outdated PR was locked due to age label Sep 6, 2022

github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022

Uh oh!

Conversation

bayandin commented Aug 2, 2022

Uh oh!

carlocab commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayandin commented Aug 2, 2022

Uh oh!

carlocab commented Aug 2, 2022

Uh oh!

Bo98 commented Aug 2, 2022

Uh oh!

This comment was marked as outdated.

carlocab commented Aug 3, 2022

Uh oh!

andig commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayandin commented Aug 3, 2022

Uh oh!

andig commented Aug 3, 2022

Uh oh!

bayandin commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlocab commented Aug 3, 2022

Uh oh!

andig commented Aug 3, 2022

Uh oh!

carlocab commented Aug 3, 2022

Uh oh!

andig commented Aug 3, 2022

Uh oh!

andig commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andig commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bayandin commented Aug 4, 2022

Uh oh!

Uh oh!

bayandin commented Aug 5, 2022

Uh oh!

carlocab commented Aug 5, 2022

Uh oh!

bayandin commented Aug 6, 2022

Uh oh!

BrewTestBot commented Aug 6, 2022

Uh oh!

BrewTestBot commented Aug 6, 2022

Uh oh!

BrewTestBot commented Aug 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

carlocab commented Aug 2, 2022 •

edited

Loading

andig commented Aug 3, 2022 •

edited

Loading

bayandin commented Aug 3, 2022 •

edited

Loading

andig commented Aug 3, 2022 •

edited

Loading

andig commented Aug 4, 2022 •

edited

Loading